This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
V0.16.x upgrade node forge #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
requested review from
hugomrdias,
dignifiedquire,
jacobheun and
vasco-santos
This was referenced Sep 23, 2019
|
@dignifiedquire can you release this as a |
hugomrdias
approved these changes
Sep 23, 2019
|
done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades
node-forgedependency to the same one used bylibp2p-keychainin order to downgradelibp2p-keychain'speer-iddependency to the same version as thelibp2pin order to upgradeipfsto use the latestlibp2pand still be able to dial other nodes on the network.Phew.
This is necessary because otherwise
node-forgecomplains thatsha512is an unknown hash algorithm.N.b. this PR is against the branch
v0.16.xand not master, which isv0.17.0so needs to be released as0.16.2.Also upgrades
aegirtov20because for whatever reason the tests weren't running on browsers withv18any more. It upgradesstandardso there's some refactoring noise in this PR.