This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
fix!: use @helia/delegated-routing-v1-http-api-client internally #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the internal implementation to use the [@helia/delegated-routing-v1-http-api-client](https://www.npmjs.com/package/@helia/delegated-routing-v1-http-api-client) instead of a hand-rolled version. BREAKING CHANGE: the module has been renamed as the spec has been renamed
BigLep
reviewed
Oct 26, 2023
|
|
||
| This is a [ContentRouting](https://libp2p.github.io/js-libp2p/interfaces/_libp2p_interface.content_routing.ContentRouting.html) | ||
| implementation that makes use of the [@helia/delegated-routing-v1-http-api-client](https://www.npmjs.com/package/@helia/delegated-routing-v1-http-api-client) | ||
| to use servers that implement the snappily-titled [Delegated Routing V1 HTTP API](Delegated Routing V1 HTTP API) |
There was a problem hiding this comment.
I assume we mean to link to https://specs.ipfs.tech/routing/http-routing-v1/ ?
|
|
||
| const node = await createLibp2p({ | ||
| contentRouters: [ | ||
| reframeContentRouting('https://cid.contact/reframe') | ||
| delgatedRoutingV1HTTPAPIContentRouting('https://example.org') |
There was a problem hiding this comment.
When ipshipyard/waterworks-community#1 lands (EOW week I expect), delegated-ipfs.dev will be a good default.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the internal implementation to use the @helia/delegated-routing-v1-http-api-client instead of a hand-rolled version.
Replaces any older references to "Reframe" with the new name of "Delegated Routing V1 HTTP API". Phew.
BREAKING CHANGE: the module has been renamed as the spec has been renamed