Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relay: make only 1 reservation per peer #2974

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Sep 23, 2024

We only need 1 reservation per peer.

This PR also proactively removes relay reservations on disconnecting from the peer. This helps when the relay client is restarting frequently.

Fixes: #2963

We only need 1 reservation per peer.

This PR also proactively removes relay reservations on disconnecting
from the peer. This helps when the relay client is restarting
frequently.
Copy link
Collaborator

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mod some nits

p2p/protocol/circuitv2/relay/constraints_test.go Outdated Show resolved Hide resolved
p2p/protocol/circuitv2/relay/constraints.go Outdated Show resolved Hide resolved
p2p/protocol/circuitv2/relay/resources.go Show resolved Hide resolved
@sukunrt sukunrt merged commit 299f964 into master Oct 4, 2024
11 checks passed
@MarcoPolo MarcoPolo mentioned this pull request Oct 17, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relay: recycle reservations for the same peer
2 participants