config: fix AddrFactory for AutoNAT #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
addrfactory-fix
branch
3 times, most recently
from
503f91b
to
b8d0297
Compare
MarcoPolo
approved these changes
Jul 31, 2024
config/config.go
Outdated
| fx.Invoke(func(h *bhost.BasicHost, lifecycle fx.Lifecycle) (*autorelay.AutoRelay, error) { | ||
| // oldAddrFactory is the AddrFactory before it's modified by autorelay | ||
| // we need this for checking reachability via autonat | ||
| oldAddrFactory := func(addrs []ma.Multiaddr) []ma.Multiaddr { |
There was a problem hiding this comment.
it's a bike shed, but slight preference for originalAddrFactory
There was a problem hiding this comment.
I pushed a commit to that effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the address factory before it's modified by autorelay