Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: provide separate docker-compose files for OSX and Linux #2397

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

marten-seemann
Copy link
Contributor

Fixes #2387.

I wish there was a better way to do this, but I can't figure out.

Any idea how to test this end-to-end in CI? Would be great if we could set up a node and check that the swarm dashboard shows a connection, but I don't want to build a HTML parser.

Comment on lines +10 to +12
extra_hosts: # define a host.docker.internal alias, so we can use the same datasources.yml and prometheus.yml on Linux and OSX
- "host.docker.internal:127.0.0.1"
grafana:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be the gateway address(172.17.0.1), right?
https://docs.docker.com/compose/compose-file/compose-file-v3/#extra_hosts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately that doesn't work. Kubo is only listening on 127.0.0.1 for the metrics endpoint.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I missed the line above it. This will work with this network_mode: "host"

dashboards/README.md Outdated Show resolved Hide resolved
Co-authored-by: Marco Munizaga <git@marcopolo.io>
@marten-seemann marten-seemann merged commit d616720 into master Jun 28, 2023
@MarcoPolo MarcoPolo mentioned this pull request Jul 14, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics: problems with docker-compose setup
3 participants