Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcmgr: register prometheus metrics with the libp2p registerer #2370

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Jun 15, 2023

If the caller forgot to call rcmgrObs.MustRegisterWith, we will still get the metrics. If they have a StatsTraceReporter, they're anyway updating the counters. If they didn't provide a StatsTraceReporter, we will have registered a few extra metrics with prometheus.

fixes: #2371

Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update in the rcmgr dashboard README that the user doesn't have to call MustRegisterWith any more?

@sukunrt
Copy link
Member Author

sukunrt commented Jun 15, 2023

@marten-seemann good catch! I've updated the README.

@MarcoPolo
Copy link
Collaborator

Ah thanks, this is great :)

@marten-seemann marten-seemann mentioned this pull request Jun 21, 2023
29 tasks
@marten-seemann marten-seemann merged commit dfaeb7e into master Jun 21, 2023
@sukunrt sukunrt deleted the sukun/rcmgr-register-metrics branch June 23, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register resource manager metrics with libp2p prometheus registerer
3 participants