test: rcmgr: Snapshot defaults and test that we keep consistent defaults #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarcoPolo What's the status of this PR? |
|
@marten-seemann should be ready to go after a review |
| @@ -134,7 +134,12 @@ func TestDefaultsDontChange(t *testing.T) { | |||
|
|
|||
| defaultsFromFile, err := os.ReadFile("limit_config_test_default.json") | |||
| require.NoError(t, err) | |||
| require.Equal(t, defaultsFromFile, jsonBytes) | |||
|
|
|||
| // replace crlf with lf because of windows | |||
marten-seemann
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No logical changes. Adds a test to make sure we don't silently break the defaults by snapshotting the current default state. If we change the defaults the diff will show what changed.