Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add some users to the readme #1981

Merged
merged 7 commits into from
Jan 13, 2023
Merged

feat: add some users to the readme #1981

merged 7 commits into from
Jan 13, 2023

Conversation

p-shahi
Copy link
Member

@p-shahi p-shahi commented Jan 5, 2023

No description provided.

marten-seemann
marten-seemann reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we define some minimum inclusion criteria here?

I have such a list in quic-go and it helps to have a policy when people asked to be included.

@p-shahi
Copy link
Member Author

p-shahi commented Jan 5, 2023

I see quic-go also lists GitHub stars in its list. Is that the criteria you apply? If so, perhaps 200 star minimum threshold?

@marten-seemann
Copy link
Contributor

If so, perhaps 200 star minimum threshold?

I think the quic-go cutoff is 1000 stars, with an exception made for Ooni.

@p-shahi
Copy link
Member Author

p-shahi commented Jan 5, 2023

If so, perhaps 200 star minimum threshold?

I think the quic-go cutoff is 1000 stars, with an exception made for Ooni.

The majority of projects on this list are below 1000 stars, so that would be too high of a cutoff. If we do use stars, let's do 250 so we can include Wasp/IOTA

@mudler
Copy link
Contributor

mudler commented Jan 6, 2023

That looks nice!

Friendly poke from here 👋 @marten-seemann @vyzo

BigLep
BigLep reviewed Jan 9, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@p-shahi
Copy link
Member Author

p-shahi commented Jan 10, 2023

@marten-seemann @MarcoPolo may I get a 👍 on this one?

p-shahi and others added 2 commits January 9, 2023 20:26
@p-shahi
Update README.md
389bbb0
@p-shahi @BigLep
Update README.md
8109d06 
Co-authored-by: Steve Loeppky <stvn@loeppky.com>
marten-seemann
marten-seemann approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add Berty as well? Other than that, lgtm.

README.md Outdated Show resolved Hide resolved
p-shahi and others added 2 commits January 12, 2023 16:43
@p-shahi @marten-seemann
Update README.md
ea003eb 
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
@p-shahi
Update README.md
cc33733
@p-shahi p-shahi merged commit a4e16ef into master Jan 13, 2023
@p-shahi p-shahi deleted the add-users branch January 13, 2023 00:47
This was referenced Jul 27, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigLep BigLep BigLep left review comments

@marten-seemann marten-seemann marten-seemann approved these changes

@MarcoPolo MarcoPolo Awaiting requested review from MarcoPolo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@p-shahi @marten-seemann @mudler @BigLep