Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(basic_host): stream not closed when context done #1148

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

godcong
Copy link
Contributor

@godcong godcong commented Aug 3, 2021

When i create some NewStream
A long time later,GetStreams() resulted many unused stream.
Finnally, I found the cause of the error

@Stebalien
Copy link
Member

The context governs creation of the stream, not the lifetime of the stream.

@Stebalien Stebalien closed this Aug 3, 2021
@Stebalien
Copy link
Member

Oh, wait. Nvm. I should read code.

@Stebalien Stebalien reopened this Aug 3, 2021
@Stebalien
Copy link
Member

Thanks for catching this!

@Stebalien Stebalien merged commit aaef2e0 into libp2p:master Aug 3, 2021
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants