AutoNAT fails to close its peerstore #2743
Comments
Stebalien
added a commit
that referenced
this issue
Mar 19, 2024
To do this, I've had to move a few leaky tests into a separate package. I've filed a bug for the AutoNAT issue (#2743) but the "error on startup" issue is going to require some pretty invasive changes (we need to construct _then_ start).
MarcoPolo
added a commit
that referenced
this issue
Mar 21, 2024
) * config: refactor AutoNAT construction into separate method * config: use a lifecycle hook to start listening on swarm addresses * use Fx to construct the host * add a test for constructing a routed host * use Fx hooks to start the host * config: use Fx lifecycle hooks to start AutoRelay and for PeerRouting * basichost: don't close the swarm The swarm is not constructed by the basic host, thus is shouldn't be closed by it. * config: use Fx hook to close the quicreuse connection manager * test for goroutine leaks when starting/stopping fx To do this, I've had to move a few leaky tests into a separate package. I've filed a bug for the AutoNAT issue (#2743) but the "error on startup" issue is going to require some pretty invasive changes (we need to construct _then_ start). * go fmt * Ignore one more top function * Typo * Ignore any not top --------- Co-authored-by: Sukun <sukunrt@gmail.com> Co-authored-by: Steven Allen <steven@stebalien.com> Co-authored-by: Marco Munizaga <git@marcopolo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The AutoNAT service creates a peerstore but fails to close it, leaking goroutines.
The text was updated successfully, but these errors were encountered: