Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basichost can remember invalid protocol preference #142

Open
whyrusleeping opened this issue Nov 5, 2016 · 3 comments
Open

basichost can remember invalid protocol preference #142

whyrusleeping opened this issue Nov 5, 2016 · 3 comments
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked

Comments

@whyrusleeping
Copy link
Contributor

If i connect node A to node B, and they speak bitswap 1.1.0, node B will remember that node A supports that protocol. if node A is then downgraded to only support bitswap 1.0.0, node B will still attempt to only communicate over bitswap 1.1.0, resulting in a failure to communicate.

@whyrusleeping whyrusleeping added the kind/bug A bug in existing code (including security flaws) label Nov 5, 2016
@Kubuxu
Copy link
Member

Kubuxu commented Nov 6, 2016

So after failure of the "remembered" protocol we should reset the state and start from ground zero.

@whyrusleeping
Copy link
Contributor Author

Yeah, that's what I'm thinking too. It's not simple though

On Sun, Nov 6, 2016, 04:17 Jakub Sztandera notifications@github.com wrote:

So after failure of the "remembered" protocol we should reset the state
and start from ground zero.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#142 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABL4HP0Bl8eY6Wtie3-DsCw7staASuqjks5q7cVJgaJpZM4Kqaw2
.

@Kubuxu
Copy link
Member

Kubuxu commented Nov 28, 2016

@whyrusleeping was this fixed?

@Kubuxu Kubuxu added the status/ready Ready to be worked label Nov 28, 2016
@daviddias daviddias added exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue labels Aug 19, 2017
marten-seemann pushed a commit that referenced this issue Apr 21, 2022
dep: update multidadr for protocol migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

3 participants