This repository has been archived by the owner on May 26, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233.
errors.Is
anderrors.As
still confuses me. What was happening here was that thecase
for the version negotiation errors didn't recognize aquic.VersionNegotiationError
because... well, I don't really know.I assume it's because a
*quic.VersionNegotiationError
has (exported) fields, anderrors.Is
was looking for an exact match, not just a type match. This is whaterrors.As
apparently does.The same applies to a bunch of other error types as well.
With this PR, we should be able to properly increment the counter for version negotiation errors (and the other error types), instead of creating a new Prometheus counter for every error.