Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PutValue not blocked by Provide during bootstrapping #29

Merged
merged 1 commit into from
May 2, 2019

Conversation

aschmahmann
Copy link
Contributor

A quick fix for #28 that makes sending out Provide messages in PubSub bootstrapping non-blocking.

…messages in PubSub bootstrapping non-blocking
if err != nil {
log.Warningf("bootstrapPubsub: error providing rendezvous for %s: %s", topic, err.Error())
}

for {
select {
case <-time.After(8 * time.Hour):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make this shorter, 8hrs might be too long with the churn we have in the dht.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea but let's merge this first.

@vyzo vyzo requested a review from Stebalien May 2, 2019 20:28
if err != nil {
log.Warningf("bootstrapPubsub: error providing rendezvous for %s: %s", topic, err.Error())
}

for {
select {
case <-time.After(8 * time.Hour):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea but let's merge this first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants