Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routing table refresh should NOT block #705

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Routing table refresh should NOT block #705

merged 2 commits into from
Jul 21, 2021

Conversation

aarshkshah1992
Copy link
Contributor

Closes #609 .

Stebalien
Stebalien approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could potentially cause us to stack goroutines, but that's unlikely. This can't be triggered from the network.

@Stebalien Stebalien merged commit 35cca9a into master Jul 21, 2021
@Stebalien Stebalien deleted the feat/unlock-refresh branch July 21, 2021 04:00
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@aschmahmann aschmahmann Awaiting requested review from aschmahmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RefreshRoutingTable should not block
2 participants
@aarshkshah1992 @Stebalien