This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
remove deprecated Bytes method from the Key interface #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
remove-bytes-from-key-interface
branch
from
85d8734
to
7b11ee6
Compare
marten-seemann
force-pushed
the
remove-bytes-from-key-interface
branch
from
7b11ee6
to
36adc8d
Compare
Stebalien
approved these changes
Jul 22, 2021
|
@marten-seemann it looks like the deprecation here wasn't quite "correct". Unfortunately, we have quite a few packages that still use it. I'm fixing them, but we might want to consider reverting before releasing (for now). |
Doesn't that just mean that we were negligent fixing our own code? Why would we revert this, if we can just fix it (replacing |
We signaled deprecation with "DEPRECATED" instead of "Deprecated: " so |
lukasz-zimnoch
added a commit
to keep-network/keep-core
that referenced
this pull request
Sep 28, 2021
The aforementioned method was deprecated and removed in `v0.9.0` of `go-libp2p-core`. The recommended replacement is using the `crypto.MarshalPublicKey` function. See: libp2p/go-libp2p-core#204
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method has been deprecated since May 2019.