DoH resolver implementation #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
requested changes
Apr 8, 2021
aschmahmann
approved these changes
Apr 8, 2021
Contributor
aschmahmann
left a comment
aschmahmann
left a comment
There was a problem hiding this comment.
I'm not so familiar with the DoH specifics, but it looks like you're just using the libraries and testing against actual DoH servers in the wild and it works.
If @lidel is happy then I'm happy 😄
Collaborator
Author
|
Updated for go-multiaddr-dns@v0.3.0, as the upstream dependency has been merged. Awaiting @lidel's review. |
lidel
approved these changes
Apr 9, 2021
Member
lidel
left a comment
lidel
left a comment
There was a problem hiding this comment.
LGTM. Some suggestions for improved tests below, but no blockers.
| "testing" | ||
| ) | ||
|
|
||
| func TestLookupIPAddr(t *testing.T) { |
Member
There was a problem hiding this comment.
Would be good to have an explicit check that confirms this returns both ipv4 AND ipv6 (libp2p.io has both, so good candidate)
Collaborator
Author
There was a problem hiding this comment.
sure, let me do that/
Co-authored-by: Marcin Rataj <lidel@lidel.org>
9 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on multiformats/go-multiaddr-dns#26TBD: