Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export P2PNode class #48

Merged
merged 1 commit into from
Aug 26, 2019
Merged

export P2PNode class #48

merged 1 commit into from
Aug 26, 2019

Conversation

emad-elsaid
Copy link
Contributor

current snippet doesn't export P2PNode class, so when you try to require it in src/index.js it doesn't find the class returning an error:

const peer = new P2PNode({peerInfo})
^
TypeError: P2PNode is not a constructor

so that change should export P2PNode

@emad-elsaid emad-elsaid mentioned this pull request Jul 17, 2019
Merged
@raulk raulk requested a review from yusefnapora August 24, 2019 15:01
yusefnapora
yusefnapora approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@yusefnapora yusefnapora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@yusefnapora yusefnapora merged commit 7173007 into libp2p:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obo20 obo20 obo20 approved these changes

@yusefnapora yusefnapora yusefnapora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emad-elsaid @yusefnapora @obo20