update javascript.md #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was two problems for me to run that code: 1- Missing import for `Ping` 2- `remoteAddr` instead of wrong `addr` in `pingRemotePeer()` function I couldn't run my code without these changes Hope it fix other's problems too (if there's any)!
|
@mehranabi thanks for the contribution! @yusefnapora – could you have a quick peek? Thanks! |
yusefnapora
approved these changes
May 6, 2019
|
Thank you guys (and all other contributers) for this awesome project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was two problems for me to run that code:
1- Missing import for
Ping2-
remoteAddrinstead of wrongaddrinpingRemotePeer()functionI couldn't run my code without these changes
Hope it fix other's problems too (if there's any)!