Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Allow passing general objects by value to kernels #676

Merged

Conversation

noelchalmers
Copy link
Contributor

Description

Title says it all. tests/src/core/kernel.cpp shows the intended usage, and tests/src/c/kernel.cpp shows the equivalent C API usage (C needs the argument wrapped in an occaStruct object).

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #676 (b674a1e) into development (cbdd074) will increase coverage by 0.00%.
The diff coverage is 63.63%.

❗ Current head b674a1e differs from pull request most recent head 9575900. Consider uploading reports for the commit 9575900 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #676   +/-   ##
============================================
  Coverage        76.23%   76.23%           
============================================
  Files              291      291           
  Lines            18798    18807    +9     
============================================
+ Hits             14330    14337    +7     
- Misses            4468     4470    +2     
Impacted Files Coverage Δ
src/core/kernelArg.cpp 79.48% <55.55%> (-1.43%) ⬇️
include/occa/core/kernelArg.hpp 47.36% <100.00%> (+6.19%) ⬆️

... and 3 files with indirect coverage changes

@kris-rowe kris-rowe merged commit a25bd3d into libocca:development May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants