Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake/Make/bin] Remove vestigial MPI support #611

Merged

Conversation

SFrijters
Copy link
Contributor

Description

PR #608 removed MPI support, after this compile_cpp_mpi_example_with_modes was
unused so it can be removed as well.

PR libocca#608 removed MPI support, after this compile_cpp_mpi_example_with_modes was
unused so it can be removed as well.
@SFrijters SFrijters force-pushed the feature-clean-up-mpi-examples branch from 9a260b9 to ff750a6 Compare August 1, 2022 12:36
@SFrijters SFrijters changed the title [CMake] Remove vestigial MPI test support [CMake] Remove vestigial MPI example support Aug 1, 2022
@SFrijters SFrijters changed the title [CMake] Remove vestigial MPI example support [CMake/Make/bin] Remove vestigial MPI support Aug 1, 2022
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #611 (65409a1) into development (d30000b) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #611      +/-   ##
===============================================
+ Coverage        77.25%   77.28%   +0.02%     
===============================================
  Files              262      258       -4     
  Lines            19568    19394     -174     
===============================================
- Hits             15118    14988     -130     
+ Misses            4450     4406      -44     
Impacted Files Coverage Δ
src/occa/internal/bin/occa.cpp 37.32% <ø> (+0.12%) ⬆️
src/c/kernel_fortran_interface.cpp 0.00% <0.00%> (-10.00%) ⬇️
src/occa/internal/utils/store.hpp 90.62% <0.00%> (-6.25%) ⬇️
src/occa/internal/utils/string.hpp 92.98% <0.00%> (-4.72%) ⬇️
src/occa/internal/utils/sys.cpp 73.95% <0.00%> (-3.31%) ⬇️
src/dtype/builtins.cpp 44.44% <0.00%> (-2.78%) ⬇️
src/c/base.cpp 84.88% <0.00%> (-2.33%) ⬇️
src/occa/internal/modes/serial/registration.cpp 91.11% <0.00%> (-2.23%) ⬇️
src/occa/internal/utils/env.cpp 81.01% <0.00%> (-1.27%) ⬇️
...a/internal/lang/statement/declarationStatement.cpp 94.00% <0.00%> (-1.05%) ⬇️
... and 11 more

@kris-rowe
Copy link
Member

Good catch!

@kris-rowe kris-rowe merged commit d75a2ff into libocca:development Aug 1, 2022
@SFrijters SFrijters deleted the feature-clean-up-mpi-examples branch August 1, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants