-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature device synchronization #609
Feature device synchronization #609
Conversation
Codecov Report
@@ Coverage Diff @@
## development #609 +/- ##
=============================================
Coverage 77.26% 77.26%
=============================================
Files 261 258 -3
Lines 19554 19392 -162
=============================================
- Hits 15109 14984 -125
+ Misses 4445 4408 -37
|
Currently we have occaFinish()/occa::finish() as c/c++ API. If I didn't miss this doesn't seem include the exposure of stream::finish() and device::finishAll() to that end. I am wondering if/how it would come later. BTW this change would make the implementation (and API) much clear IMO. |
…modeStream_t::finish`.
71a79bf
to
cff8faa
Compare
Good catch. I was thinking to add this later, however I might as well do it now before it is merged so that it isn't forgotten. |
* Adds `finishAll` function to synchronize all streams on a device. * Adds `stream::finish` to synchronize a specific stream. * Adds C and Fortran interfaces for both
Description
Closes #598.
This could be split into 2 separate PRs: the first implementing
stream::finish()
and a subsequent one implementingdevice::finishAll()
; however, the need forstream::finish
is less clear outside of the current context.