Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYS] Fix frequency units #601

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Conversation

noelchalmers
Copy link
Contributor

Description

CPU frequency displays the wrong units in occa info. The frequency is parsed from lscpu in MHz was converting to KHz, but the stringifyFrequency routine assumes it is in Hz.

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #601 (0aae5fa) into main (6289743) will decrease coverage by 0.79%.
The diff coverage is 100.00%.

❗ Current head 0aae5fa differs from pull request most recent head 681760c. Consider uploading reports for the commit 681760c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
- Coverage   77.33%   76.54%   -0.80%     
==========================================
  Files         264      264              
  Lines       19544    19477      -67     
==========================================
- Hits        15114    14908     -206     
- Misses       4430     4569     +139     
Impacted Files Coverage Δ
src/occa/internal/utils/sys.cpp 80.48% <100.00%> (+2.95%) ⬆️
src/occa/internal/core/launchedKernel.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/occa/internal/core/launchedDevice.cpp 0.00% <0.00%> (-79.67%) ⬇️
include/occa/types/json.tpp 45.45% <0.00%> (-24.55%) ⬇️
src/occa/internal/lang/expr/callNode.cpp 73.68% <0.00%> (-9.22%) ⬇️
include/occa/types/json.hpp 75.40% <0.00%> (-6.75%) ⬇️
src/dtype/builtins.cpp 41.66% <0.00%> (-5.56%) ⬇️
src/occa/internal/utils/string.cpp 81.33% <0.00%> (-4.00%) ⬇️
src/occa/internal/utils/styling.cpp 93.45% <0.00%> (-3.74%) ⬇️
src/occa/internal/modes/serial/registration.cpp 91.11% <0.00%> (-2.23%) ⬇️
... and 17 more

@kris-rowe kris-rowe merged commit 7447dd6 into libocca:main Jul 12, 2022
kris-rowe pushed a commit that referenced this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants