Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIP] Fix compiler error and warnings #547

Merged
merged 3 commits into from
Dec 17, 2021

Conversation

noelchalmers
Copy link
Contributor

Description

Fixes #546 and addresses a couple other compiler warnings when compiling with HIP support.

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #547 (52b3347) into main (7dd3c62) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 52b3347 differs from pull request most recent head 631142a. Consider uploading reports for the commit 631142a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
- Coverage   76.35%   76.34%   -0.01%     
==========================================
  Files         262      262              
  Lines       19522    19520       -2     
==========================================
- Hits        14906    14903       -3     
- Misses       4616     4617       +1     
Impacted Files Coverage Δ
src/occa/internal/lang/specialMacros.cpp 59.60% <0.00%> (-0.67%) ⬇️
src/occa/internal/utils/sys.cpp 76.45% <0.00%> (-0.11%) ⬇️

Copy link
Member

@kris-rowe kris-rowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@noelchalmers noelchalmers merged commit 6f6c4f4 into libocca:main Dec 17, 2021
@noelchalmers noelchalmers deleted the bugfix/nonBlockingStreams branch December 17, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HIP] Compilation errors with non-blocking stream creation
2 participants