Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings #329

Merged
merged 15 commits into from
May 31, 2020
Merged

Fix compiler warnings #329

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3e56817
[Fix] Fix shadowing warnings
SFrijters Apr 20, 2020
4073210
[Fix] Implicit conversions to unsigned integers
SFrijters Apr 20, 2020
96411e5
[Fix] Missing return statements for non-void functions
SFrijters Apr 20, 2020
c1b2bf5
[Test] Fix JSON serialization test
SFrijters Apr 20, 2020
a82ceab
[Fix] Possibly unset variables
SFrijters Apr 20, 2020
05a3a8a
[Fix] Baseclass should be initialized explicitly in copy constructor
SFrijters Apr 20, 2020
ca4b1f6
[Fix] Implicit fallthrough
SFrijters Apr 20, 2020
efdefe0
[Fix] Catching polymorphic type by value
SFrijters Apr 20, 2020
2f80d64
[Fix] Add missing template specializations for areEqual
SFrijters Apr 20, 2020
86841df
[Fix] Suppress unused variable warnings for OpenCL polyfill
SFrijters Apr 20, 2020
9d5078f
[Fix] Be more strict about floating point numbers
SFrijters Apr 20, 2020
05f7ac2
[Fix] Conversion warnings by changing fabs to std::abs
SFrijters Apr 20, 2020
e144223
[CMake] Set warning flags for C code and enable -Werror for Debug builds
SFrijters Apr 20, 2020
d60edee
Merge branch 'master' into fix-compiler-warnings
dmed256 May 30, 2020
9de1cf5
Merge branch 'master' into fix-compiler-warnings
dmed256 May 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Fix] Implicit fallthrough
  • Loading branch information
@SFrijters
SFrijters committed May 29, 2020
commit ca4b1f6eea495d4738c9008642f549b7549750ea
3 changes: 3 additions & 0 deletions src/c/types.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@ namespace occa {
if (value.value.ptr == NULL) {
return occa::json(occa::json::null_);
}
/* FALLTHRU */
default:
OCCA_FORCE_ERROR("Invalid value type");
return occa::json();
Expand Down Expand Up @@ -597,6 +598,8 @@ namespace occa {
if (mem) {
return *(mem->dtype_);
}
OCCA_FORCE_ERROR("Invalid pointer type");
return dtype::none;
}
default:
OCCA_FORCE_ERROR("Invalid value type");
Expand Down