Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIP] Adds support for hip-nvcc (Thanks @noelchalmers!) #266

Merged
merged 3 commits into from
Dec 5, 2019

Conversation

dmed256
Copy link
Member

@dmed256 dmed256 commented Dec 4, 2019

Description

Adds some fixes provided by @noelchalmers to help support HIP-NVCC

@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #266 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
- Coverage   73.66%   73.63%   -0.03%     
==========================================
  Files         282      282              
  Lines       19520    19537      +17     
==========================================
+ Hits        14380    14387       +7     
- Misses       5140     5150      +10
Impacted Files Coverage Δ
src/tools/env.cpp 77.31% <0%> (-3.65%) ⬇️
include/occa/tools/json.hpp 73.55% <0%> (-1.88%) ⬇️

@dmed256 dmed256 force-pushed the hip/add-support-for-hip-nvcc branch 2 times, most recently from d8c998c to ec89f5c Compare December 5, 2019 07:07
@dmed256 dmed256 force-pushed the hip/add-support-for-hip-nvcc branch from ec89f5c to 893c858 Compare December 5, 2019 15:51
@dmed256 dmed256 merged commit 6e6f6f0 into master Dec 5, 2019
@dmed256 dmed256 deleted the hip/add-support-for-hip-nvcc branch December 5, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants