add squeeze and unsqueeze #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmh530
approved these changes
Apr 18, 2020
Contributor
jmh530
left a comment
jmh530
left a comment
There was a problem hiding this comment.
LGTM.
It occurs to me that there is a connection with numir's unsqueeze.
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
+ Coverage 91.28% 91.33% +0.05%
==========================================
Files 51 51
Lines 8961 9030 +69
==========================================
+ Hits 8180 8248 +68
- Misses 781 782 +1
Continue to review full report at Codecov.
|
Member
Author
|
good point. I found numir API is more friendly and universal. Reworked now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.