✨ Support polymorphic catch #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The multi_virtual demo currently segfaults due to the action table having a very large next action offset for some reason. Maybe this has exposed a bug we haven't seen before. |
Exception algorithm will now check if a parent type exists within the thrown object that can be caught by a catch block. There is a limit of up to 12 relationships that can exist for a thrown object. Any greater than that and the exception mechanism will call `std::terminate()`. A relationship is a connection from parent to child object. With virtual inheritance, an additional relationship is made for each virtual parent inheritance. - 🐛 Fix `read_sleb128()`, incorrectly sign extends values. - 🐛 Fix `get_action_decoder()` next action record offset. Resolves #6
kammce
force-pushed
the
poly-morphic-catch
branch
from
6ffd52a to
85b06a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception algorithm will now check if a parent type exists within the thrown object that can be caught by a catch block. There is a limit of up to 12 relationships that can exist for a thrown object. Any greater than that and the exception mechanism will call
std::terminate(). A relationship is a connection from parent to child object. With virtual inheritance, an additional relationship is made for each virtual parent inheritance.Resolves #6
read_sleb128(), incorrectly sign extends values.get_action_decoder()next action record offset.