-
Notifications
You must be signed in to change notification settings - Fork 8
✨ STM32F1 Timer #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
✨ STM32F1 Timer #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kammce
approved these changes
May 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things to fix up in some wording. And ignore the things I recommended you change for the demos. We can add that in the next change. Otherwise, everything looks great!
- Added timer interface for stm32f1 series - Added a working demo for the stm32f1 timer - Added generic timer helper/interface for STM32 MCUs - Updated general_purpose_timer to use a manager Note: This is an unpolished, but working commit. Will improve it.
- Updated demo to rename it and clean it up - Added new function to check if a specific interrupt vector is enabled - Improved and cleaned up commenting - Fixed schedule timing calculation to accomodate edge cases - Removed remnants of basic_timer to be added in separate PR - Moved some manager functions from protected to public
- Updated timer managers to track resource allocation. Prevents reusing of same timer for incompatible features such as callbacks & pwm. - Tested and working copy for both the callback functionality as well as pwm generation.
2676704
to
968232f
Compare
- Updated and fixed documentation - Removed now redundant static pwm availability variable - Updated resource_count to just raw count instead of bit mask - Added reset_peripheral function to power.cpp
kammce
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6
hal::stm32f1::timer
interfacehal::stm32f1::pwm
availability
member variable to track pinslibhal-arm-mcu/stm32f1/timer
manager_data
member variable to track timer state informationlibhal-arm-mcu/stm32f1/interrupt
is_interrupt_enabled
function to check if an interrupt vector is already being usedlibhal-arm-mcu/stm32f1/power
reset_peripheral
function to allow resets for peripherals