Skip to content

Make GTCredential from GTCredentialProviderBlock optional #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2016
Merged

Make GTCredential from GTCredentialProviderBlock optional #580

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfa48e4
make returned credential optional
alehed Jun 27, 2016
2a9ccda
only use _Nullable in header file
alehed Jun 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ObjectiveGit/GTCredential.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ NS_ASSUME_NONNULL_BEGIN
///
/// credentialBlock - a block that will be called when credentials are requested.
/// Must not be nil.
+ (instancetype)providerWithBlock:(GTCredential *(^)(GTCredentialType type, NSString *URL, NSString *userName))credentialBlock;
+ (instancetype)providerWithBlock:(GTCredential * _Nullable(^)(GTCredentialType type, NSString *URL, NSString *userName))credentialBlock;

/// Default credential provider method.
///
Expand All @@ -46,7 +46,7 @@ NS_ASSUME_NONNULL_BEGIN
/// type - the credential types allowed by the operation.
/// URL - the URL the operation is authenticating against.
/// userName - the user name provided by the operation. Can be nil, and might be ignored.
- (GTCredential *)credentialForType:(GTCredentialType)type URL:(NSString *)URL userName:(nullable NSString *)userName;
- (GTCredential * _Nullable)credentialForType:(GTCredentialType)type URL:(NSString *)URL userName:(nullable NSString *)userName;
@end

/// The GTCredential class is used to provide authentication data.
Expand Down