Expose -moveHEAD #535
Merged
Expose -moveHEAD #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…veHEADToCommit:error: to the header so they can be used from apps. This seems important because I'm told the only legitimate way to move the HEAD is with these methods (and the underlying git2 functions) and NOT to delete and recreate the HEAD reference manually, so these methods must be public if client apps need to move the HEAD.
| @@ -269,6 +269,22 @@ extern NSString * const GTRepositoryInitOptionsOriginURLString; | |||
| /// Returns a GTReference or nil if an error occurs. | |||
| - (nullable GTReference *)headReferenceWithError:(NSError **)error; | |||
|
|
|||
| /// Move HEAD reference safely, since deleting and recreating HEAD is always wrong. | |||
| /// | |||
| /// reference - The new target reference for HEAD. | |||
There was a problem hiding this comment.
Style nit: could you align the - for the args?
There was a problem hiding this comment.
Looks like this one was missed 😄
|
Just a style nit. Thanks! |
|
|
|
|
|
|
|
🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose move HEAD operations through public API. Includes tests.
Supersedes #515 from @wilshipley