Don’t try to add nil strings to an array.
#408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can occur if one or more of the strings in `strarray` is invalid UTF8.
|
👍 This is certainly better than crashing. I recall running into a thing where ASCII worked where UTF8 didn't (https://twitter.com/jspahrsummers/status/453653597989777408) but I can't for the life of me remember the context. Maybe we should try to fall back to ASCII if UTF8 fails? |
|
There’s at least one case where we’re doing UTF8, falling back to ISOLatin1, falling back to MacRoman. I’m not sure if that’s the better approach or if UTF8 falling back to ASCII is. I’m surprised that there’s no error parameter for any of those constructors, or the corresponding |
|
Yeah the lack of errors is a bummer. Maybe use the lossy ASCII conversion? Seems like that's most likely to actually give us something. |
|
Good call 👍 |
|
🔶 |
|
🎇 |
joshaber
added a commit
that referenced
this pull request
Sep 5, 2014
Don’t try to add `nil` strings to an array.
phatblat
pushed a commit
to phatblat/objective-git
that referenced
this pull request
Sep 13, 2014
Don’t try to add `nil` strings to an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can occur if one or more of the strings in
strarrayis invalid UTF8.We’ve got a user seeing this when we’re pulling in their branch names. The on-disk
.git/refs/*look ok, but I wonder if there’s something funky going on with the decomposed UTF16 filenames → assumed valid null-terminated UTF8 conversion in@(cStr).To wit, I think we should probably not be assuming valid null-terminated UTF8 here, but I’m not sure what we should assume instead.
I haven’t been able to synthesize a failing case (of filename →
nilstring literal) yet.