Skip to content

Added -resetPathspecs:... #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 7, 2014
Merged

Added -resetPathspecs:... #351

merged 8 commits into from
Apr 7, 2014

Conversation

joshaber
Copy link
Member

@joshaber joshaber commented Apr 4, 2014

No description provided.

@joshaber joshaber changed the title [WIP] Added -resetPaths:... Added -resetPaths:... Apr 7, 2014
@joshaber
Copy link
Member Author

joshaber commented Apr 7, 2014

This is ready for review 🙏

@jspahrsummers jspahrsummers self-assigned this Apr 7, 2014
/// error - The error if one occurred.
///
/// Returns whether the reset was succcessful.
- (BOOL)resetToCommit:(GTCommit *)commit withResetType:(GTRepositoryResetType)resetType error:(NSError **)error;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can GTRepositoryResetType be defined in this header?

@jspahrsummers
Copy link
Contributor

Can you add a test for the other reset method too?

@joshaber
Copy link
Member Author

joshaber commented Apr 7, 2014

🚴

@joshaber joshaber changed the title Added -resetPaths:... Added -resetPathspecs:... Apr 7, 2014

#import "GTRepository.h"

/// The rest types. See the libgit2 documentation for more info.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*reset

@jspahrsummers
Copy link
Contributor

😆

@joshaber
Copy link
Member Author

joshaber commented Apr 7, 2014

😐

@jspahrsummers
Copy link
Contributor

jspahrsummers added a commit that referenced this pull request Apr 7, 2014
@jspahrsummers jspahrsummers merged commit 59101bf into master Apr 7, 2014
@jspahrsummers jspahrsummers deleted the add-reset branch April 7, 2014 21:57
phatblat pushed a commit to phatblat/objective-git that referenced this pull request Sep 13, 2014
@jspahrsummers jspahrsummers removed their assignment May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants