Added Pushing to and Pulling from a repository #329
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,6 +18,8 @@ | |||
| // remote - The underlying `git_remote` object. | |||
| - (id)initWithGitRemote:(git_remote *)remote; | |||
|
|
|||
| - (id)initWithGitRepository:(git_repository *)repository name:(NSString *)name url:(NSString *)url error:(NSError **)error; | |||
There was a problem hiding this comment.
Why does this take a git_repository instead of a GTRepository?
There was a problem hiding this comment.
Style: needs documentation; URL should be capitalized and probably be URLString since it's not an actual NSURL.
|
Thanks! I stopped there on the review because it seems like the PR isn't quite ready yet. There's a lot of |
|
Thanks, I'll fix it up. |
phatblat
pushed a commit
to phatblat/objective-git
that referenced
this pull request
Nov 11, 2014
phatblat
pushed a commit
to phatblat/objective-git
that referenced
this pull request
Nov 12, 2014
This is a rework of @johnbeatty's efforts in libgit2#329
Merged
|
Superseded by #419. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.