Fetch support. #224
Fetch support. #224
Conversation
which is waiting for merging in libgit2/libgit2#1729
ghost
assigned 
| @@ -127,6 +128,10 @@ - (NSString *)remoteName { | |||
| return [[NSString alloc] initWithBytes:name length:end - name encoding:NSUTF8StringEncoding]; | |||
| } | |||
|
|
|||
| - (GTRemote *)remote { | |||
| return [GTRemote remoteWithName:[self remoteName] inRepository:[self repository]]; | |||
There was a problem hiding this comment.
Style: dot syntax, since these methods don't have externally-visible side effects.
|
🍄 Can you please also merge from |
|
🌻 |
|
|
||
| - (id)initWithGitRemote:(git_remote *)remote; | ||
|
|
||
| // The underlying `git_remote` object. | ||
| - (git_remote *)git_remote __attribute__((objc_returns_inner_pointer)); | ||
|
|
||
| - (BOOL)fetchWithError:(NSError **)error credentials:(int (^)(git_cred **cred, GTCredentialType allowedTypes, NSString *url, NSString *username))credBlock progress:(void (^)(NSString *message, int length))progressBlock completion:(int (^)(GTRemoteCompletionType type))completionBlock updateTips:(int (^)(GTReference *ref, GTOID *a, GTOID *b))updateTipsBlock; |
There was a problem hiding this comment.
Yeah, the name isn't right. What about
-cancelOperation? I'm not really against*stopparameters, but the caller of the block ought to still have access to the specific remote under consideration to call it, and I can't really add the*stopparameter tocredentialBlockbecause it won't always be needed.
I don't think the credential block needs a BOOL *stop, but the rest should have one. The remote is still accessible, because any code that could pass in these blocks will also know the GTRemote object, and can just capture it.
There was a problem hiding this comment.
That's more or less what I was saying ;-). I'll add *stop parameters then.
| } | ||
|
|
||
| - (BOOL)updatesFetchHead { | ||
| return git_remote_update_fetchhead(self.git_remote) == 1; |
There was a problem hiding this comment.
I don't see anywhere that specifies this will return 1. We should probably compare != 0 instead.
|
Thanks! Just a few more notes. |
|
I'll work on a few of these comments and commit. |
… instance variable access.
|
@jspahrsummers There are only two changes missing, I'm waiting on your comments on those (options dictionary, which is similar to what we currently have for clone). |
|
Okay, good to go. As a bonus, I added a remote clone test against the libgit2 documentation if you set some environment variables — I'm overly cautious around pointer-thingy changes ;-). |
| @@ -67,6 +67,26 @@ + (NSError *)git_errorFor:(int)code description:(NSString *)desc failureReason:( | |||
| return [NSError errorWithDomain:GTGitErrorDomain code:code userInfo:userInfo]; | |||
| } | |||
|
|
|||
| + (NSError *)git_errorFor:(int)code description:(NSString *)desc userInfo:(NSDictionary *)additionalUserInfo failureReason:(NSString *)reason, ... { | |||
| NSMutableDictionary *userInfo = [NSMutableDictionary dictionaryWithDictionary:additionalUserInfo]; | |||
There was a problem hiding this comment.
This can use -mutableCopy.
There was a problem hiding this comment.
Yeah, I was so annoyed by the duplication between this and the one above that it just flew above my head 😧.
|
This looks really great. Thanks, and sorry for the delay! 🙇 |
Fetch support.
This supersedes #203.
It looks mostly ready so I'm open to suggestions. It misses tests (again :-S) and documentation.