GTOID improvements #206
Merged
GTOID improvements #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -9,7 +9,7 @@ | |||
| #import "git2.h" | |||
|
|
|||
| // Represents an object ID. | |||
| @interface GTOID : NSObject | |||
| @interface GTOID : NSObject < NSCopying > | |||
There was a problem hiding this comment.
Style: no spaces on either side of NSCopying.
|
Awesome, thanks! Just some style notes. |
| @@ -32,6 +32,10 @@ | |||
| NSString *secondSHA = @"82dc47f6ba3beecab33080a1136d8913098e1801"; | |||
| expect(testOID).notTo.equal([[GTOID alloc] initWithSHA:secondSHA]); | |||
| }); | |||
|
|
|||
| it(@"should compare equal to an OID created with the same SHA from a C string", ^{ | |||
| expect(testOID).to.equal([[GTOID alloc] initWithSHACString: "f7ecd8f4404d3a388efbff6711f1bdf28ffd16a0"]); | |||
|
I think now I am done with the GTOID class. I started another branch (https://github.com/5sw/objective-git/tree/use_gtoid) where I change the use of the plain |
| // Initializes the receiver by converting the given SHA to an OID | ||
| // optionally returning a NSError instance on failure. | ||
| // | ||
| // SHA - The to convert to an OID. Cannot be nil. |
|
Loving this work @5sw! It would be great to have some unit tests for the new inintializers though. |
|
Close! Mostly just a couple style notes. ⛵ |
|
OK, fixed those style issues, added the better error message and some unit tests for the error-returning initializers. |
|
💥 🎆 Thanks! |
|
✨ |
phatblat
pushed a commit
to phatblat/objective-git
that referenced
this pull request
Sep 13, 2014
GTOID improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.