Extending checkout support #457

Activity

1. tiennou commented on Apr 8, 2015

   

   tiennou

   on Apr 8, 2015

   ContributorAuthor

   More actions

   Note that I'm throwing that out to see if you guys already have some plans on how to do that.

   What I would do is add a GTCheckoutOptions (bike-shedding welcome) value-object with a nice and tasty API to wrap the current uses we have while shielding us from the need to change a bunch of places each time we have to convert users' need to libgit2 git_checkout_options.

   So, for example, our checkout support would change to :

   GTCheckoutOptions *options = [blah checkoutOptionsWithStrategy:strategy notifyFlags:flags progressBlock:progress notifyBlock:notify];
   
   BOOL success = [repository checkoutCommit:myCommit options:options error:NULL];
   

   or you could customize them before handing those to whatever you're trying to do :

   GTCheckoutOptions *options = [blah checkoutOptionsWithStrategy:strategy notifyFlags:flags progressBlock:progress notifyBlock:notify];
   
   options.paths = @[@"src", "include"];
   
   GTReference *originMaster = [GTReference referenceByLookingUpReferencedNamed:@"origin/master"];
   
   BOOL success = [repository mergeReference:originMaster options:options error:NULL];
   

   (obviously this last example is completely made up, because I don't think we're that far in handling merges yet).
2. tiennou commented on Apr 8, 2015

   

   tiennou

   on Apr 8, 2015

   ContributorAuthor

   More actions

   Eeek. I don't think it's even sensible to ask for a merge with paths. Let's hope the point gets through anyway 😄.
3. jspahrsummers commented on Apr 10, 2015

   

   jspahrsummers

   on Apr 10, 2015

   Contributor

   More actions

   Sounds reasonable. We don't use libgit2 checkout ourselves, so I don't feel qualified to comment on the use of its API.
4. jspahrsummers

   added

   enhancement

   on Apr 10, 2015
5. tiennou

   added a commit that references this issue on Apr 10, 2015

   Wrap all the various way of doing checkouts in GTCheckoutOptions

   ...

   This issue will close once commit de9f512 is merged into the 'master' branch.

   de9f512
6. tiennou

   added a commit that references this issue on Sep 8, 2015

   Wrap all the various way of doing checkouts in GTCheckoutOptions

   ...

   This issue will close once commit 4edb350 is merged into the 'master' branch.

   4edb350
7. tiennou

   added a commit that references this issue on Jun 28, 2016

   Wrap all the various way of doing checkouts in GTCheckoutOptions

   ...

   This issue will close once commit c6607dc is merged into the 'master' branch.

   c6607dc
8. tiennou

   added a commit that references this issue on Jul 18, 2016

   Wrap all the various way of doing checkouts in GTCheckoutOptions

   ...

   This issue will close once commit ace15a7 is merged into the 'master' branch.

   ace15a7
9. tiennou

   added a commit that references this issue on Aug 15, 2016

   Wrap all the various way of doing checkouts in GTCheckoutOptions

   ...

   This issue will close once commit fb80c7c is merged into the 'master' branch.

   fb80c7c
10. tiennou

    added a commit that references this issue on Dec 18, 2016

    Wrap all the various way of doing checkouts in GTCheckoutOptions

    ...

    This issue will close once commit b65755c is merged into the 'master' branch.

    b65755c
11. tiennou

    added a commit that references this issue on Jan 15, 2017

    Wrap all the various way of doing checkouts in GTCheckoutOptions

    ...

    This issue will close once commit 311ca45 is merged into the 'master' branch.

    311ca45
12. pietbrauer

    closed this as completedin #459on Feb 27, 2017