Bring the GitRemoteCallbacks structure in sync with libgit2 #2173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The marshaling was messed up due to missing extra field. Fixes libgit2#2161
|
@arrowd I don't think you were looking at the right version of the libgit2 code when doing your investigations. LibGit2Sharp is currently using v1.8.4, and that version of the |
|
The mentioned issue was talking exactly about using non-bundled libgit2 version. I realize that this PR can't be merged as of now, but it will come in handy if libgit2sharp would bump its bundled libgit2. |
A non-bundled version still needs to be v1.8.4 to be compatible with LibGit2Sharp. I'm going to go ahead and close this for now then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The marshaling was messed up due to missing extra field.
Fixes #2161