Update libgit2 to ef5a385 #1728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethomson
force-pushed
the
ethomson/update_libgit2
branch
2 times, most recently
from
886b74a to
8fc106c
Compare
URLs without a path are perfectly valid; the path is implicitly `/`. libgit2 was incorrectly rejecting these paths, and LibGit2Sharp was incorrectly testing this bad behavior. Remove this test now that libgit2 has fixed this issue.
ethomson
force-pushed
the
ethomson/update_libgit2
branch
from
18416a9 to
64ab971
Compare
|
Thank you both! |
ghost
referenced
this pull request
in mendix/libgit2sharp
Dec 15, 2020
ghost
referenced
this pull request
in mendix/libgit2sharp
Dec 16, 2020
* Cherry-pick Merge pull request #1728 from libgit2/ethomson/update_libgit2 Co-authored-by: Edward Thomson <ethomson@edwardthomson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although libgit2 hasn't yet started locking down for its next release, it should be 🔜 . We can start readying our prereleases to match.