Skip to content

Conversation

@jwonagel
Copy link

Added Factory for initializing Proxyoptions with GitProxyType Auto.
From issue #1429

@reegeek
Copy link

reegeek commented Sep 23, 2019

hi,

When this PR will be merged ?
Regards,

@seshonaar
Copy link

seshonaar commented Dec 5, 2019

Please note that when the port is missing in the proxy URL, libgit2 will crash (default_port is not initialized).
LE: I reported the issue to libgit
libgit2/libgit2#5323

@seshonaar
Copy link

The issue on the libgit2 side is fixed in master, but not on the maintenance branch (0.28.*), that is used by libgit2sharp

Added configurable Proxyoptions to all commands connecting to a remote
@jwonagel
Copy link
Author

Proxy can be configured in PushOptions, FetchOptionsBase and RemoteOptions. The behavior does not change.

@florenzen
Copy link

I would really like to see this Pull Request merged and released. We are using libgit2sharp in an internal tool and have absolutely have to use a proxy. Therefore, I applied the PR branch on the v0.26.2 tag in our fork and it works perfectly (see https://github.com/enertrag/libgit2sharp/releases/tag/v0.26.2_proxy-options). But I'd rather reference a NuGet package than including our own build of this library.

@jwonagel jwonagel closed this Nov 19, 2020
@jwonagel jwonagel deleted the jwonagel/proxy_options_initializing branch November 19, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants