Make Repository.IsValid() return false on empty paths #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fication to: * throw on null arguments * return false on string.Empty
|
Something went wrong, I think. The two commits are still there. Something like this below should do the trick Either I can fix that for you and manually merge your PR, or you can try it out by yourself. |
|
please fix it by your self, won't fix on my side... |
|
@ptr1120 No problem. Thanks for the help and the thorough test coverage! Cheers |
|
Superseded by #1156 |
ptr1120
deleted the
Repository.IsValid_should_only_throw_on_null_arguments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #818