Add a ReInit function #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libgit2 stores the lookup paths for gitconfig files in its global state. This means that after a program changes its effective uid libgit2 will still look for gitconfig files in the home directory of the original uid. Expose a way to call C.git_libgit2_init so a user can reinitialize the libgit2 global state.
lhchavez
reviewed
Sep 28, 2020
Go does not allow you to call the package init() function, so instead add a new function to initialize libgit2 and use that function to reduce the repetition in ReInit()
|
thanks @lhchavez for taking a look, I pushed a commit to reduce the repetition, which seems to work fine, though I am not super happy with the function naming. |
That name is fine. Since it's a private function, if you ever come up with a better alternative, we can change it without fear of breaking anything! |
lhchavez
approved these changes
Sep 29, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2020
libgit2 stores the lookup paths for gitconfig files in its global state. This means that after a program changes its effective uid libgit2 will still look for gitconfig files in the home directory of the original uid. Expose a way to call C.git_libgit2_init so a user can reinitialize the libgit2 global state. (cherry picked from commit 3c5c580)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2020
libgit2 stores the lookup paths for gitconfig files in its global state. This means that after a program changes its effective uid libgit2 will still look for gitconfig files in the home directory of the original uid. Expose a way to call C.git_libgit2_init so a user can reinitialize the libgit2 global state. (cherry picked from commit 3c5c580)
lhchavez
pushed a commit
that referenced
this pull request
Sep 29, 2020
libgit2 stores the lookup paths for gitconfig files in its global state. This means that after a program changes its effective uid libgit2 will still look for gitconfig files in the home directory of the original uid. Expose a way to call C.git_libgit2_init so a user can reinitialize the libgit2 global state. (cherry picked from commit 3c5c580) Co-authored-by: Jesse Hathaway <jesse@mbuki-mvuki.org>
lhchavez
pushed a commit
that referenced
this pull request
Sep 29, 2020
libgit2 stores the lookup paths for gitconfig files in its global state. This means that after a program changes its effective uid libgit2 will still look for gitconfig files in the home directory of the original uid. Expose a way to call C.git_libgit2_init so a user can reinitialize the libgit2 global state. (cherry picked from commit 3c5c580) Co-authored-by: Jesse Hathaway <jesse@mbuki-mvuki.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libgit2 stores the lookup paths for gitconfig files in its global state.
This means that after a program changes its effective uid libgit2 will
still look for gitconfig files in the home directory of the original
uid. Expose a way to call C.git_libgit2_init so a user can reinitialize
the libgit2 global state.