Skip to content

Fix null pointer dereference in status.ByIndex #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 14, 2020

Conversation

mbfr
Copy link
Contributor

@mbfr mbfr commented Aug 14, 2020

git_status_byindex can return a null pointer if there is no statuses.

Copy link
Contributor

@lhchavez lhchavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks! just some small requests.

mbfr and others added 4 commits August 14, 2020 15:05
Add suggested error message on return

Co-authored-by: lhchavez <lhchavez@lhchavez.com>
Move setting struct values into struct initialisation

Co-authored-by: lhchavez <lhchavez@lhchavez.com>
Early exit test if preconditions are not met

Co-authored-by: lhchavez <lhchavez@lhchavez.com>
@lhchavez lhchavez merged commit fc6eaf3 into libgit2:master Aug 14, 2020
lhchavez pushed a commit that referenced this pull request Aug 15, 2020
`git_status_byindex` can return a null pointer if there is no statuses.

(cherry picked from commit fc6eaf3)
lhchavez pushed a commit that referenced this pull request Aug 15, 2020
`git_status_byindex` can return a null pointer if there is no statuses.

(cherry picked from commit fc6eaf3)
lhchavez pushed a commit that referenced this pull request Aug 15, 2020
`git_status_byindex` can return a null pointer if there is no statuses.

(cherry picked from commit fc6eaf3)
lhchavez pushed a commit that referenced this pull request Aug 15, 2020
`git_status_byindex` can return a null pointer if there is no statuses.

(cherry picked from commit fc6eaf3)
lhchavez pushed a commit that referenced this pull request Aug 16, 2020
`git_status_byindex` can return a null pointer if there is no statuses.

(cherry picked from commit fc6eaf3)
lhchavez pushed a commit that referenced this pull request Aug 16, 2020
`git_status_byindex` can return a null pointer if there is no statuses.

(cherry picked from commit fc6eaf3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants