Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install geos.h header file in cmake builds #607

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

tbussmann
Copy link
Contributor

since the change from autoconf to cmake this header was not longer installed with make install

@pramsey
Copy link
Member

pramsey commented May 20, 2022

On the one hand I like the idea of geos.h pulling in the "official C++ API", we've deprecated the C++ since 15 years ago.

https://github.com/libgeos/geos/blame/main/include/geos/geom.h#L144

Wonder what @dbaston thinks?

@dbaston
Copy link
Member

dbaston commented May 20, 2022

Sounds fine to me, once we decide what the "C++ API" is :)

@pramsey
Copy link
Member

pramsey commented May 20, 2022

Yeah! I was wondering if these headers even still worked. Like, can I write the C++ example apps up in terms of just "include geos.h and go". I have no idea how deep the dependency graph reaches once you include it.

@tbussmann
Copy link
Contributor Author

I don't know if and how often that header is used for quick access to the deprecated C++ API, but no longer providing it seems to be an unintended change introduced by the switch to the cmake-only build system. If you conclude leaving this out helps to transition away of it, the readme.md should be adopted, at least.

@pramsey
Copy link
Member

pramsey commented Jun 6, 2022

Taking this one in, I think it's good for the future (maybe) but good to retain continuity with the past until/if we deliberately change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants