Store price to BigDecimal #271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henu
force-pushed
the
price_in_bigdecimal
branch
from
f8fa1e7 to
b3ddb99
Compare
|
Automatic tests found some problems. Now they are fixed, and waiting for new run... |
henu
force-pushed
the
price_in_bigdecimal
branch
from
b3ddb99 to
d2f7ed4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How about storing price as BigDecimal? It's perfect type for price information, as you can avoid floating point rounding errors and have as many decimal places as you want.
I'm not an expert in developing Java libraries, so please suggest how to make this PR better!
I'm only able to test it with Android Google payments.