Fix #24: Migrate FuseArgs away from using Optparse
#95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first of a 3-patch series of commits to address libfuse#24 This commit introduces tests for the current `Optparse` based implementation to ensure that the next commit doesn't break current usage compatibility. The next commit would introduce the `ArgumentParser` based implementation. The final commit will attempt to do some minor clean up to make the code a bit more idomatic / pythonic.
This PR changes the `Optparse` based implementation to one base on `ArgumentParser` for `FuseArgs`, without touching the tests introduced in the previous commit. We delete the `subbedopts` sub-module and implemented all of the argument parsing/handling in the main Fuse/FuseArgs implementation.
|
The PR is split into distinct commits:
This ensures that we maintain backwards compatibility. I could break these into 2 separate PRs if that would be easier to review / track. |
lonetwin
changed the title
FuseArgs away from using Optparse
|
Seems like there's a bit more work left on this w.r.t parsing strings that have implicit arguments such as Aside: It might seem like we'd have to add some deprecation messages for code that relies on |
|
Thanks, that looks promising. Please fix the tests that fail to now start in the CI, and we'll then take it from there. |
sdelafond
added a commit
that referenced
this pull request
Apr 3, 2025
|
@lonetwin can you please rebase on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #24. It replaces the
Optpasebased implementation ofFuseArgsto one based onArgumentParserand also adds some tests for the parsing functionality.