Fix fann_error buffer overflow #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please double check that I don't have win so I could not test it... |
|
In addition to those changes, I think the vsprintf / sprintf unsecure call should be avoid and replace by vsnprintf / snprintf. |
steffennissen
added a commit
that referenced
this pull request
Aug 16, 2014
Fix fann_error buffer overflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in fann_error function. The
errstrstring was limited by FANN_ERRSTR_MAX (128) characters. It caused buffer overflow for all error messages with longer file path as a parameter (FANN_E_CANT_READ_CONFIG,FANN_E_CANT_OPEN_CONFIG_R...). It obviously resulted in the heap corruption...In addition there was a memory leak for
errstrwhenerrdatwas NULL.This patch fixes both bugs. I checked it with valgrind and also run all my test tests that I have in my php fann ext.