Fix zone detection for subdomain DNS record management #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves a bug where DirectAdmin provider attempted to create DNS records in non-existent zones for subdomain requests. For example, when managing host.subdomain.domain.com, the provider incorrectly tried to use zone subdomain.domain.com instead of the actual managed zone domain.com. Key changes: - Add findManageableZone() with parent zone traversal algorithm - Add getDomainList() to retrieve available DirectAdmin domains - Add adjustRecordForZone() for proper subdomain record name handling - Update all CRUD operations to use detected manageable zones - Add comprehensive test coverage for zone detection scenarios - Add LIBDNS_DA_NON_ROOT_TEST_ZONE environment variable for testing This fix enables proper ACME challenge handling for subdomains in Caddy server deployments, resolving "Domain does not belong to you" errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a bug where DirectAdmin provider attempted to create DNS records in non-existent zones for subdomain requests. For example, when managing host.subdomain.domain.com, the provider incorrectly tried to use zone subdomain.domain.com instead of the actual managed zone domain.com.
Key changes:
This fix enables proper ACME challenge handling for subdomains in Caddy server deployments, resolving "Domain does not belong to you" errors.