curl_container: allow calling GetContent without CurlHolder #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be relevant when the parameters need to be passed to some different library (i.e. libmpv, gstreamer) and there is no cpr::Session to get a CurlHolder from. Signed-off-by: Sebastian Muxel <sebastian@muxel.dev>
muxelplexer
force-pushed
the
muxelplexer/getcontent
branch
from
04dda7c to
68044a4
Compare
COM8
requested changes
Sep 20, 2025
| void Add(const std::initializer_list<T>&); | ||
| void Add(const T&); | ||
|
|
||
| const std::string GetContent(const CurlHolder&) const; |
There was a problem hiding this comment.
Could you please add a docs comment to the old function as well?
| * Returns the URL while ignoring `encode`. This allows calling without | ||
| * active `CurlHolder`. | ||
| **/ | ||
| const std::string GetContent() const; |
There was a problem hiding this comment.
Please add tests inside test/structures_tests.cpp.
|
For running clang-format there is: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be relevant when the parameters need to be passed to some different library (i.e. libmpv, gstreamer) and there is no cpr::Session to get a CurlHolder from.
I ran the clang-format script - it brought up issues but not with the file i touched. If there is a better way already implemented please let me know :)