Include "module" information in Sym type #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the Breakpad parser to properly parse "MODULE" lines and store the mentioned module. With upcoming changes we intend to expose the module that a symbol belongs to through the symbolization APIs. Signed-off-by: Daniel Müller <deso@posteo.net>
So far the library has not exposed the binary file that a symbol resides in. With this change we introduce the symbolize::Sym::module member to provide this information. Signed-off-by: Daniel Müller <deso@posteo.net>
Add the module attribute to the blaze_sym struct, providing access to the module information that we previously added to the Rust API from C. Signed-off-by: Daniel Müller <deso@posteo.net>
danielocfb
force-pushed
the
topic/module
branch
2 times, most recently
from
6f0c144 to
3ff7307
Compare
|
I'll go ahead and merge this to unblock follow-on work, but feel free to leave comments and I'll address them, Andrii. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits for descriptions.