Open
Conversation
Refs libMesh#4387 Currently on some Mac builds we're seeing: ../src/utils/xdr_cxx.C:565:12: error: cast from 'int (*)(XDR *, int *)' (aka 'int (*)(__rpc_xdr *, int *)') to 'xdrproc_t' (aka 'int (*)(__rpc_xdr *, void *, unsigned int)') converts to incompatible function type [-Werror,-Wcast-function-type-mismatch] 565 | return (xdrproc_t)(xdr_int); I'd think "Are the XDR procs of type xdrproc?" would be an "Is the Pope Catholic?" sort of question, but here we are.
jwpeterson
reviewed
Feb 5, 2026
| // builds when trying to pass XDR's own functions to xdrproc_t | ||
| // arguments - apparently because the xdr_foo functions now only take | ||
| // two arguments? We'll add some shims to convert them. | ||
| #ifdef __APPLE__ |
Member
There was a problem hiding this comment.
Does this workaround also apply to previous versions of MacOS where we never had this problem in the first place? In other words, is checking __APPLE__ sufficient here, or do you have to check for a specific version as well?
|
Job Coverage, step Generate coverage on 5bd031f wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4387
Currently on some Mac builds we're seeing:
../src/utils/xdr_cxx.C:565:12: error: cast from 'int (*)(XDR *, int )' (aka 'int ()(__rpc_xdr *, int )') to 'xdrproc_t' (aka 'int ()(__rpc_xdr *, void *, unsigned int)') converts to incompatible function type [-Werror,-Wcast-function-type-mismatch]
565 | return (xdrproc_t)(xdr_int);
I'd think "Are the XDR procs of type xdrproc?" would be an "Is the Pope Catholic?" sort of question, but here we are.
Also, at least on my system while testing a fix for the above, I encountered the fact that my MacOSX SDK's rpc.h can define
xdr_longas takingint*rather thanlong*, so I added a workaround for that case.This is passing my initial tests; hopefully CI will catch anything I missed.